netdev - Re: Unix domain socket missing error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpUF5rAXy7M5S=4tYtNKAnrmTHk+=1M9CR8xqj9VgSYqDg@mail.gmail.com>
Date:   Mon, 18 Nov 2019 21:43:07 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Adeel Sharif <madeel.sharif@...glemail.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: Unix domain socket missing error code

On Tue, Nov 12, 2019 at 12:56 AM Adeel Sharif
<madeel.sharif@...glemail.com> wrote:
>
> It should but it is not used when two different sockets are communicating.
> This is the third check in the if statement and it is never called
> because the first unlikely check was false:
>
> if (other != sk &&
>         unlikely(unix_peer(other) != sk && unix_recvq_full(other))) {
>

Good catch!

It seems you already have a reproducer to trigger this OOM? If so
please share. And let me see if and how I can fix it.

Thanks.