netdev - Re: [PATCH bpf-next] selftests/bpf: enforce no-ALU32 for test_progs-no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7317c35c-d8f2-25d4-d40d-6d27b99a1c6e@fb.com>
Date:   Wed, 20 Nov 2019 00:32:17 +0000
From:   Yonghong Song <yhs@...com>
To:     Andrii Nakryiko <andriin@...com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        "daniel@...earbox.net" <daniel@...earbox.net>
CC:     "andrii.nakryiko@...il.com" <andrii.nakryiko@...il.com>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next] selftests/bpf: enforce no-ALU32 for
 test_progs-no_alu32



On 11/19/19 4:25 PM, Andrii Nakryiko wrote:
> With the most recent Clang, alu32 is enabled by default if -mcpu=probe or
> -mcpu=v3 is specified. Use a separate build rule with -mcpu=v2 to enforce no

A little bit clarification -mcpu=probe may not enable alu32 for old 
kernels. alu32 enabled with -mcpu=probe only if kernel supports jmp32, 
which is merged in January this year.

> ALU32 mode.
> 
> Suggested-by: Yonghong Song <yhs@...com>
> Signed-off-by: Andrii Nakryiko <andriin@...com>

With the above nit,
Acked-by: Yonghong Song <yhs@...com>