netdev - Re: [PATCH net-next v5 0/3] cxgb4: add TC-MATCHALL classifier offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191119163519.07765c0c@cakuba.netronome.com>
Date:   Tue, 19 Nov 2019 16:35:19 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jiri@...nulli.us,
        nirranjan@...lsio.com, vishal@...lsio.com, dt@...lsio.com
Subject: Re: [PATCH net-next v5 0/3] cxgb4: add TC-MATCHALL classifier
 offload

On Wed, 20 Nov 2019 05:46:05 +0530, Rahul Lakkireddy wrote:
> This series of patches add support to offload TC-MATCHALL classifier
> to hardware to classify all outgoing and incoming traffic on the
> underlying port. Only 1 egress and 1 ingress rule each can be
> offloaded on the underlying port.
> 
> Patch 1 adds support for TC-MATCHALL classifier offload on the egress
> side. TC-POLICE is the only action that can be offloaded on the egress
> side and is used to rate limit all outgoing traffic to specified max
> rate.
> 
> Patch 2 adds logic to reject the current rule offload if its priority
> conflicts with existing rules in the TCAM.
> 
> Patch 3 adds support for TC-MATCHALL classifier offload on the ingress
> side. The same set of actions supported by existing TC-FLOWER
> classifier offload can be applied on all the incoming traffic.
> 
> Thanks,
> Rahul
> 
> v5:
> - Fixed commit message and comment to include comparison for equal
>   priority in patch 2.

LGTM, thanks!