netdev - Re: [PATCH bpf-next] tools: bpf: fix build for 'make -s tools/bpf O=<dir>'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191121085232.GC31576@pc-11.home>
Date:   Thu, 21 Nov 2019 09:52:32 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Quentin Monnet <quentin.monnet@...ronome.com>
Cc:     Alexei Starovoitov <ast@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, oss-drivers@...ronome.com,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH bpf-next] tools: bpf: fix build for 'make -s tools/bpf
 O=<dir>'

On Tue, Nov 19, 2019 at 10:56:26AM +0000, Quentin Monnet wrote:
> Building selftests with 'make TARGETS=bpf kselftest' was fixed in commit
> 55d554f5d140 ("tools: bpf: Use !building_out_of_srctree to determine
> srctree"). However, by updating $(srctree) in tools/bpf/Makefile for
> in-tree builds only, we leave out the case where we pass an output
> directory to build BPF tools, but $(srctree) is not set. This
> typically happens for:
> 
>     $ make -s tools/bpf O=/tmp/foo
>     Makefile:40: /tools/build/Makefile.feature: No such file or directory
> 
> Fix it by updating $(srctree) in the Makefile not only for out-of-tree
> builds, but also if $(srctree) is empty.
> 
> Detected with test_bpftool_build.sh.
> 
> Fixes: 55d554f5d140 ("tools: bpf: Use !building_out_of_srctree to determine srctree")
> Cc: Shuah Khan <skhan@...uxfoundation.org>
> Signed-off-by: Quentin Monnet <quentin.monnet@...ronome.com>
> Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thanks!