netdev - Re: [PATCH iproute2-next] devlink: fix requiring either handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191121085637.GA2234@nanopsycho>
Date:   Thu, 21 Nov 2019 09:56:37 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     dsahern@...il.com, stephen@...workplumber.org,
        netdev@...r.kernel.org, oss-drivers@...ronome.com,
        Shalom Toledo <shalomt@...lanox.com>,
        Quentin Monnet <quentin.monnet@...ronome.com>
Subject: Re: [PATCH iproute2-next] devlink: fix requiring either handle

Wed, Nov 20, 2019 at 06:56:06PM CET, jakub.kicinski@...ronome.com wrote:
>devlink sb occupancy show requires device or port handle.
>It passes both device and port handle bits as required to
>dl_argv_parse() so since commit 1896b100af46 ("devlink: catch
>missing strings in dl_args_required") devlink will now
>complain that only one is present:
>
>$ devlink sb occupancy show pci/0000:06:00.0/0
>BUG: unknown argument required but not found
>
>Drop the bit for the handle which was not found from required.
>
>Reported-by: Shalom Toledo <shalomt@...lanox.com>
>Fixes: 1896b100af46 ("devlink: catch missing strings in dl_args_required")
>Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>
>Tested-by: Shalom Toledo <shalomt@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>

Thanks!