netdev - Re: [PATCH iproute2-next] devlink: fix requiring either handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56b7fcb2-f4ec-2bf4-59cb-952fcf79783a@gmail.com>
Date:   Thu, 21 Nov 2019 14:39:47 -0700
From:   David Ahern <dsahern@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     stephen@...workplumber.org, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, jiri@...nulli.us,
        Shalom Toledo <shalomt@...lanox.com>,
        Quentin Monnet <quentin.monnet@...ronome.com>
Subject: Re: [PATCH iproute2-next] devlink: fix requiring either handle

On 11/20/19 10:56 AM, Jakub Kicinski wrote:
> devlink sb occupancy show requires device or port handle.
> It passes both device and port handle bits as required to
> dl_argv_parse() so since commit 1896b100af46 ("devlink: catch
> missing strings in dl_args_required") devlink will now
> complain that only one is present:
> 
> $ devlink sb occupancy show pci/0000:06:00.0/0
> BUG: unknown argument required but not found
> 
> Drop the bit for the handle which was not found from required.
> 
> Reported-by: Shalom Toledo <shalomt@...lanox.com>
> Fixes: 1896b100af46 ("devlink: catch missing strings in dl_args_required")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>
> Tested-by: Shalom Toledo <shalomt@...lanox.com>
> ---
>  devlink/devlink.c | 1 +
>  1 file changed, 1 insertion(+)

applied to iproute2-next. Thanks