netdev - Re: [PATCH bpf-next 0/2] selftests: bpftool: skip build tests if not in tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191121085905.GD31576@pc-11.home>
Date:   Thu, 21 Nov 2019 09:59:05 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Quentin Monnet <quentin.monnet@...ronome.com>
Cc:     Alexei Starovoitov <ast@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, oss-drivers@...ronome.com,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: Re: [PATCH bpf-next 0/2] selftests: bpftool: skip build tests if not
 in tree

On Tue, Nov 19, 2019 at 10:50:08AM +0000, Quentin Monnet wrote:
> The build test script for bpftool attempts to detect the toplevel path of
> the kernel repository and attempts to build bpftool from there.
> 
> If it fails to find the correct directory, or if bpftool files are missing
> for another reason (e.g. kselftests built on a first machine and copied
> onto another, without bpftool sources), then it is preferable to skip the
> tests entirely rather than dumping useless error messages.
> 
> The first patch moves the EXIT trap in the script lower down in the code,
> to avoid tampering with return value on early exits at the beginning of the
> script; then the second patch makes sure that we skip the build tests if
> bpftool's Makefile is not found at its expected location.
> 
> Jakub Kicinski (1):
>   selftests: bpftool: skip the build test if not in tree
> 
> Quentin Monnet (1):
>   selftests: bpftool: set EXIT trap after usage function
> 
>  .../selftests/bpf/test_bpftool_build.sh       | 30 +++++++++++--------
>  1 file changed, 17 insertions(+), 13 deletions(-)

Applied, thanks!