netdev - RE: [PATCH bpf-next] selftests/bpf: ensure core_reloc_kernel is reading test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dd6f9b076bb3_30202ae8b398a5b4ad@john-XPS-13-9370.notmuch>
Date:   Thu, 21 Nov 2019 12:55:12 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com, daniel@...earbox.net
Cc:     andrii.nakryiko@...il.com, kernel-team@...com,
        Andrii Nakryiko <andriin@...com>
Subject: RE: [PATCH bpf-next] selftests/bpf: ensure core_reloc_kernel is
 reading test_progs's data only

Andrii Nakryiko wrote:
> test_core_reloc_kernel.c selftest is the only CO-RE test that reads and
> returns for validation calling thread's information (pid, tgid, comm). Thus it
> has to make sure that only test_prog's invocations are honored.
> 
> Fixes: df36e621418b ("selftests/bpf: add CO-RE relocs testing setup")
> Reported-by: Alexei Starovoitov <ast@...nel.org>
> Signed-off-by: Andrii Nakryiko <andriin@...com>
> ---
>  .../selftests/bpf/prog_tests/core_reloc.c        | 16 +++++++++++-----
>  .../selftests/bpf/progs/test_core_reloc_kernel.c |  4 ++++
>  2 files changed, 15 insertions(+), 5 deletions(-)
> 

Looks good.

Acked-by: John Fastabend <john.fastabend@...il.com>