netdev - RE: [PATCH] xdp: Fix cleanup on map free for devmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5dd701c21871b_4e932af130aba5bc48@john-XPS-13-9370.notmuch>
Date:   Thu, 21 Nov 2019 13:29:38 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>,
        daniel@...earbox.net, ast@...com
Cc:     Toke Høiland-Jørgensen <toke@...hat.com>,
        bpf@...r.kernel.org, netdev@...r.kernel.org,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Subject: RE: [PATCH] xdp: Fix cleanup on map free for devmap_hash map type

Toke Høiland-Jørgensen wrote:
> Tetsuo pointed out that it was not only the device unregister hook that was
> broken for devmap_hash types, it was also cleanup on map free. So better
> fix this as well.
> 
> While we're add it, there's no reason to allocate the netdev_map array for
              ^^^
              at
> DEVMAP_HASH, so skip that and adjust the cost accordingly.

Beyond saving space without pulling these apart the free would have gotten
fairly ugly.

> 
> Fixes: 6f9d451ab1a3 ("xdp: Add devmap_hash map type for looking up devices by hashed index")
> Reported-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> ---
>  kernel/bpf/devmap.c | 74 ++++++++++++++++++++++++++++-----------------
>  1 file changed, 46 insertions(+), 28 deletions(-)

small typo in commit message otherwise

Acked-by: John Fastabend <john.fastabend@...il.com>