netdev - Re: [PATCH] xdp: Fix cleanup on map free for devmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJ6rd7Y7ZgoKLwpQNs6dni=jhbE+2OtedwHcZ71yyry7g@mail.gmail.com>
Date:   Thu, 21 Nov 2019 23:18:36 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     Toke Høiland-Jørgensen <toke@...hat.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Subject: Re: [PATCH] xdp: Fix cleanup on map free for devmap_hash map type

On Thu, Nov 21, 2019 at 1:32 PM John Fastabend <john.fastabend@...il.com> wrote:
>
> Toke Høiland-Jørgensen wrote:
> > Tetsuo pointed out that it was not only the device unregister hook that was
> > broken for devmap_hash types, it was also cleanup on map free. So better
> > fix this as well.
> >
> > While we're add it, there's no reason to allocate the netdev_map array for
>               ^^^
>               at
> > DEVMAP_HASH, so skip that and adjust the cost accordingly.
>
> Beyond saving space without pulling these apart the free would have gotten
> fairly ugly.
>
> >
> > Fixes: 6f9d451ab1a3 ("xdp: Add devmap_hash map type for looking up devices by hashed index")
> > Reported-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> > Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> > ---
> >  kernel/bpf/devmap.c | 74 ++++++++++++++++++++++++++++-----------------
> >  1 file changed, 46 insertions(+), 28 deletions(-)
>
> small typo in commit message otherwise
>
> Acked-by: John Fastabend <john.fastabend@...il.com>

Fixed the typo and applied to bpf-next. Thanks