netdev - Re: [PATCH bpf-next] libbpf: fix bpf_object name determination for bpf_object__open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQK2p05qdqNh1vh4XCZi5pyT1u7N2CJbeaBugk9JyPtUOQ@mail.gmail.com>
Date:   Thu, 21 Nov 2019 23:20:52 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] libbpf: fix bpf_object name determination for bpf_object__open_file()

On Thu, Nov 21, 2019 at 4:36 PM Andrii Nakryiko <andriin@...com> wrote:
>
> If bpf_object__open_file() gets path like "some/dir/obj.o", it should derive
> BPF object's name as "obj" (unless overriden through opts->object_name).
> Instead, due to using `path` as a fallback value for opts->obj_name, path is
> used as is for object name, so for above example BPF object's name will be
> verbatim "some/dir/obj", which leads to all sorts of troubles, especially when
> internal maps are concern (they are using up to 8 characters of object name).
> Fix that by ensuring object_name stays NULL, unless overriden.
>
> Fixes: 291ee02b5e40 ("libbpf: Refactor bpf_object__open APIs to use common opts")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Applied to bpf-next. Thanks