netdev - Re: [net-next 05/15] ice: fix stack leakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191121142548.4bb62c55@cakuba.netronome.com>
Date:   Thu, 21 Nov 2019 14:25:48 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net, Jesse Brandeburg <jesse.brandeburg@...el.com>,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        Andrew Bowers <andrewx.bowers@...el.com>
Subject: Re: [net-next 05/15] ice: fix stack leakage

On Wed, 20 Nov 2019 23:46:02 -0800, Jeff Kirsher wrote:
> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> In the case of an invalid virtchannel request the driver
> would return uninitialized data to the VF from the PF stack
> which is a bug.  Fix by initializing the stack variable
> earlier in the function before any return paths can be taken.

I'd argue users may not want hypervisor stack to get leaked into the
VMs, and therefore this should really have a fixes tag...