netdev - Re: [net-next 05/15] ice: fix stack leakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191121.143731.45820499993617607.davem@davemloft.net>
Date:   Thu, 21 Nov 2019 14:37:31 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
        netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
        andrewx.bowers@...el.com
Subject: Re: [net-next 05/15] ice: fix stack leakage

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Thu, 21 Nov 2019 14:25:48 -0800

> On Wed, 20 Nov 2019 23:46:02 -0800, Jeff Kirsher wrote:
>> From: Jesse Brandeburg <jesse.brandeburg@...el.com>
>> 
>> In the case of an invalid virtchannel request the driver
>> would return uninitialized data to the VF from the PF stack
>> which is a bug.  Fix by initializing the stack variable
>> earlier in the function before any return paths can be taken.
> 
> I'd argue users may not want hypervisor stack to get leaked into the
> VMs, and therefore this should really have a fixes tag...

Agreed.