lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Nov 2019 19:52:25 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Andrew Lunn <andrew@...n.ch>, Russell King <rmk+kernel@...linux.org.uk> Cc: Heiner Kallweit <hkallweit1@...il.com>, Vivien Didelot <vivien.didelot@...il.com>, "David S. Miller" <davem@...emloft.net>, Sean Wang <sean.wang@...iatek.com>, Matthias Brugger <matthias.bgg@...il.com>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Felix Fietkau <nbd@...nwrt.org>, John Crispin <john@...ozen.org>, Mark Lee <Mark-MC.Lee@...iatek.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, Jose Abreu <joabreu@...opsys.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>, Michal Simek <michal.simek@...inx.com>, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-stm32@...md-mailman.stormreply.com Subject: Re: [RFC PATCH net-next] net: phylink: rename mac_link_state() op to mac_pcs_get_state() On 11/20/2019 6:17 PM, Andrew Lunn wrote: >> This is something I'd like to do to make it clearer what phylink expects >> of this function, and that it shouldn't just read-back how the MAC was >> configured. However, it will require some testing and review as it >> changes quite a lot, and there's some things, particularly in DSA, that >> don't seem quite right from a phylink point of view, such as messing >> with state->interface in this function. > > Hi Russell > > Could you have more detail about DSA issues? Do you means the 6250 > setting interface to PHY_INTERFACE_MODE_NA? > > I think you and i have pretty similar marvell hardware. So i don't > think i can do much additional testing. Ideally we want Florian to do > some testing on b53. I will try to test that across the hardware I have at hand, can take a few days to get all platforms working with net-next. At first glance, this is just a simple rename and change of return type, I would not expect problems to arise from that. -- Florian
Powered by blists - more mailing lists