netdev - Re: [PATCH net-next] net: flow_dissector: Wrap unionized VLAN fields in a struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Nov 2019 17:29:11 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Petr Machata <petrm@...lanox.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH net-next] net: flow_dissector: Wrap unionized VLAN fields
 in a struct

Fri, Nov 22, 2019 at 04:47:21PM CET, petrm@...lanox.com wrote:
>In commit a82055af5959 ("netfilter: nft_payload: add VLAN offload
>support"), VLAN fields in struct flow_dissector_key_vlan were unionized
>with the intention of introducing another field that covered the whole TCI
>header. However without a wrapping struct the subfields end up sharing the
>same bits. As a result, "tc filter add ... flower vlan_id 14" specifies not
>only vlan_id, but also vlan_priority.
>
>Fix by wrapping the individual VLAN fields in a struct.
>
>Fixes: a82055af5959 ("netfilter: nft_payload: add VLAN offload support")
>Signed-off-by: Petr Machata <petrm@...lanox.com>

Reviewed-by: Jiri Pirko <jiri@...lanox.com>