netdev - Re: [PATCH net-next] net: flow_dissector: Wrap unionized VLAN fields in a struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Nov 2019 09:44:38 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     petrm@...lanox.com
Cc:     netdev@...r.kernel.org, pablo@...filter.org
Subject: Re: [PATCH net-next] net: flow_dissector: Wrap unionized VLAN
 fields in a struct

From: Petr Machata <petrm@...lanox.com>
Date: Fri, 22 Nov 2019 15:47:21 +0000

> In commit a82055af5959 ("netfilter: nft_payload: add VLAN offload
> support"), VLAN fields in struct flow_dissector_key_vlan were unionized
> with the intention of introducing another field that covered the whole TCI
> header. However without a wrapping struct the subfields end up sharing the
> same bits. As a result, "tc filter add ... flower vlan_id 14" specifies not
> only vlan_id, but also vlan_priority.
> 
> Fix by wrapping the individual VLAN fields in a struct.
> 
> Fixes: a82055af5959 ("netfilter: nft_payload: add VLAN offload support")
> Signed-off-by: Petr Machata <petrm@...lanox.com>

Applied.