netdev - Re: [PATCH net-next 1/4] sfc: change ARFS expiry mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1574556c-a4c6-2316-fd0e-41d5e6b40f29@digitalocean.com>
Date:   Fri, 22 Nov 2019 14:44:05 -0700
From:   David Ahern <dahern@...italocean.com>
To:     Edward Cree <ecree@...arflare.com>,
        linux-net-drivers@...arflare.com, davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] sfc: change ARFS expiry mechanism

On 11/22/19 10:57 AM, Edward Cree wrote:
> The old rfs_filters_added method for determining the quota could potentially
>  allow the NIC to become filled with old filters, which never get tested for
>  expiry.  Instead, explicitly make expiry check work depend on the number of
>  filters installed, and don't count checking slots without filters in as
>  doing work.  This guarantees that each filter will be checked for expiry at
>  least once every thirty seconds (assuming the channel to which it belongs is
>  NAPI polling actively) regardless of fill level.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>
> ---
>  drivers/net/ethernet/sfc/efx.c        |  8 +++--
>  drivers/net/ethernet/sfc/efx.h        |  9 +++---
>  drivers/net/ethernet/sfc/net_driver.h | 14 ++++----
>  drivers/net/ethernet/sfc/rx.c         | 46 ++++++++++++++++-----------
>  4 files changed, 45 insertions(+), 32 deletions(-)
> 

Tested-By: David Ahern <dahern@...italocean.com>