netdev - Re: [PATCH net-next 2/4] sfc: suppress MCDI errors from ARFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c64acd8d-9431-1863-7fa1-a1de52f30306@digitalocean.com>
Date:   Fri, 22 Nov 2019 14:44:10 -0700
From:   David Ahern <dahern@...italocean.com>
To:     Edward Cree <ecree@...arflare.com>,
        linux-net-drivers@...arflare.com, davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/4] sfc: suppress MCDI errors from ARFS

On 11/22/19 10:57 AM, Edward Cree wrote:
> In high connection count usage, the NIC's filter table may be filled with
>  sufficiently many ARFS filters that further insertions fail.  As this
>  does not represent a correctness issue, do not log the resulting MCDI
>  errors.  Add a debug-level message under the (by default disabled)
>  rx_status category instead; and take the opportunity to do a little extra
>  expiry work.
> 
> Since there are now multiple workitems able to call __efx_filter_rfs_expire
>  on a given channel, it is possible for them to race and thus pass quotas
>  which, combined, exceed rfs_filter_count.  Thus, don't WARN_ON if we loop
>  all the way around the table with quota left over.
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>
> ---
>  drivers/net/ethernet/sfc/ef10.c |  8 ++++++--
>  drivers/net/ethernet/sfc/rx.c   | 28 ++++++++++++++++++++++++----
>  2 files changed, 30 insertions(+), 6 deletions(-)
> 

Tested-By: David Ahern <dahern@...italocean.com>