netdev - Re: [PATCH] mdio_bus: don't use managed reset-controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191125154327.GK6602@lunn.ch>
Date:   Mon, 25 Nov 2019 16:43:27 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     David Bauer <mail@...id-bauer.net>
Cc:     netdev@...r.kernel.org, Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] mdio_bus: don't use managed reset-controller

On Fri, Nov 22, 2019 at 10:44:51PM +0100, David Bauer wrote:
> Geert Uytterhoeven reported that using devm_reset_controller_get leads
> to a WARNING when probing a reset-controlled PHY. This is because the
> device devm_reset_controller_get gets supplied is not actually the
> one being probed.
> 
> Acquire an unmanaged reset-control as well as free the reset_control on
> unregister to fix this.
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> CC: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: David Bauer <mail@...id-bauer.net>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew