netdev - Re: [PATCH] mdio_bus: don't use managed reset-controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191125.104440.2001478537682368867.davem@davemloft.net>
Date:   Mon, 25 Nov 2019 10:44:40 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     mail@...id-bauer.net
Cc:     netdev@...r.kernel.org, geert@...ux-m68k.org, andrew@...n.ch
Subject: Re: [PATCH] mdio_bus: don't use managed reset-controller

From: David Bauer <mail@...id-bauer.net>
Date: Fri, 22 Nov 2019 22:44:51 +0100

> Geert Uytterhoeven reported that using devm_reset_controller_get leads
> to a WARNING when probing a reset-controlled PHY. This is because the
> device devm_reset_controller_get gets supplied is not actually the
> one being probed.
> 
> Acquire an unmanaged reset-control as well as free the reset_control on
> unregister to fix this.
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> CC: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: David Bauer <mail@...id-bauer.net>

Applied and queued up for -stable, thanks.