netdev - Re: [PATCH] net: sched: fix `tc -s class show` no bstats on class with nolock subqueues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191130.104452.290995378176134973.davem@davemloft.net>
Date:   Sat, 30 Nov 2019 10:44:52 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dust.li@...ux.alibaba.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        john.fastabend@...il.com, tonylu@...ux.alibaba.com,
        pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: sched: fix `tc -s class show` no bstats on class
 with nolock subqueues

From: Dust Li <dust.li@...ux.alibaba.com>
Date: Thu, 28 Nov 2019 14:29:09 +0800

> When a classful qdisc's child qdisc has set the flag
> TCQ_F_CPUSTATS (pfifo_fast for example), the child qdisc's
> cpu_bstats should be passed to gnet_stats_copy_basic(),
> but many classful qdisc didn't do that. As a result,
> `tc -s class show dev DEV` always return 0 for bytes and
> packets in this case.
> 
> Pass the child qdisc's cpu_bstats to gnet_stats_copy_basic()
> to fix this issue.
> 
> The qstats also has this problem, but it has been fixed
> in 5dd431b6b9 ("net: sched: introduce and use qstats read...")
> and bstats still remains buggy.
> 
> Fixes: 22e0f8b9322c ("net: sched: make bstats per cpu and estimator RCU safe")
> Signed-off-by: Dust Li <dust.li@...ux.alibaba.com>
> Signed-off-by: Tony Lu <tonylu@...ux.alibaba.com>

Applied and queued up for -stable.