lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Nov 2019 21:17:27 -0800 From: Cong Wang <xiyou.wangcong@...il.com> To: Dust Li <dust.li@...ux.alibaba.com> Cc: Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>, John Fastabend <john.fastabend@...il.com>, Tony Lu <tonylu@...ux.alibaba.com>, Paolo Abeni <pabeni@...hat.com>, Linux Kernel Network Developers <netdev@...r.kernel.org> Subject: Re: [PATCH] net: sched: fix `tc -s class show` no bstats on class with nolock subqueues On Wed, Nov 27, 2019 at 10:29 PM Dust Li <dust.li@...ux.alibaba.com> wrote: > > When a classful qdisc's child qdisc has set the flag > TCQ_F_CPUSTATS (pfifo_fast for example), the child qdisc's > cpu_bstats should be passed to gnet_stats_copy_basic(), > but many classful qdisc didn't do that. As a result, > `tc -s class show dev DEV` always return 0 for bytes and > packets in this case. > > Pass the child qdisc's cpu_bstats to gnet_stats_copy_basic() > to fix this issue. > > The qstats also has this problem, but it has been fixed > in 5dd431b6b9 ("net: sched: introduce and use qstats read...") > and bstats still remains buggy. > > Fixes: 22e0f8b9322c ("net: sched: make bstats per cpu and estimator RCU safe") > Signed-off-by: Dust Li <dust.li@...ux.alibaba.com> > Signed-off-by: Tony Lu <tonylu@...ux.alibaba.com> Acked-by: Cong Wang <xiyou.wangcong@...il.com>
Powered by blists - more mailing lists