netdev - Re: [PATCH v3 net] Fixed updating of ethertype in function skb_mpls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 02 Dec 2019 13:04:23 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     martinvarghesenokia@...il.com
Cc:     netdev@...r.kernel.org, pshelar@....org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us,
        martin.varghese@...ia.com
Subject: Re: [PATCH v3 net] Fixed updating of ethertype in function
 skb_mpls_pop

From: Martin Varghese <martinvarghesenokia@...il.com>
Date: Mon,  2 Dec 2019 10:49:51 +0530

> From: Martin Varghese <martin.varghese@...ia.com>
> 
> The skb_mpls_pop was not updating ethertype of an ethernet packet if the
> packet was originally received from a non ARPHRD_ETHER device.
> 
> In the below OVS data path flow, since the device corresponding to port 7
> is an l3 device (ARPHRD_NONE) the skb_mpls_pop function does not update
> the ethertype of the packet even though the previous push_eth action had
> added an ethernet header to the packet.
> 
> recirc_id(0),in_port(7),eth_type(0x8847),
> mpls(label=12/0xfffff,tc=0/0,ttl=0/0x0,bos=1/1),
> actions:push_eth(src=00:00:00:00:00:00,dst=00:00:00:00:00:00),
> pop_mpls(eth_type=0x800),4
> 
> Fixes: ed246cee09b9 ("net: core: move pop MPLS functionality from OvS to core helper")
> Signed-off-by: Martin Varghese <martin.varghese@...ia.com>

Applied and queued up for -stable, thanks.