lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 02 Dec 2019 13:13:27 -0800 (PST) From: David Miller <davem@...emloft.net> To: colin.king@...onical.com Cc: inaky@...ux.intel.com, linux-wimax@...el.com, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] i2400m/USB: fix error return when rx_size is too large From: Colin King <colin.king@...onical.com> Date: Mon, 2 Dec 2019 17:42:46 +0000 > From: Colin Ian King <colin.king@...onical.com> > > Currently when the rx_size is too large the intended error > -EINVAL is not being returned as this is being assigned to > result rather than rx_skb. Fix this be setting rx_skb > to ERR_PTR(-EINVAL) so that the error is returned in rx_skb > as originally intended. > > Addresses-Coverity: ("Unused value") > Fixes: a8ebf98f5414 ("i2400m/USB: TX and RX path backends") > Signed-off-by: Colin Ian King <colin.king@...onical.com> This leaks rx_skb, the caller is supposed to clean up rx_skb by freeing it if this function doesn't transmit it successfully.
Powered by blists - more mailing lists