netdev - Re: [PATCH] i2400m/USB: fix error return when rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11a3e023-0b8d-ce2f-8fc0-567d0d3c1980@canonical.com>
Date:   Wed, 4 Dec 2019 11:32:04 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     David Miller <davem@...emloft.net>
Cc:     inaky@...ux.intel.com, linux-wimax@...el.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2400m/USB: fix error return when rx_size is too large

On 02/12/2019 21:13, David Miller wrote:
> From: Colin King <colin.king@...onical.com>
> Date: Mon,  2 Dec 2019 17:42:46 +0000
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Currently when the rx_size is too large the intended error
>> -EINVAL is not being returned as this is being assigned to
>> result rather than rx_skb. Fix this be setting rx_skb
>> to ERR_PTR(-EINVAL) so that the error is returned in rx_skb
>> as originally intended.
>>
>> Addresses-Coverity: ("Unused value")
>> Fixes: a8ebf98f5414 ("i2400m/USB: TX and RX path backends")
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> This leaks rx_skb, the caller is supposed to clean up rx_skb
> by freeing it if this function doesn't transmit it successfully.
> 
Oops, yes. Ignore this fix.

Colin