lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Dec 2019 19:17:05 +0800 From: Dust Li <dust.li@...ux.alibaba.com> To: David Miller <davem@...emloft.net> Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us, john.fastabend@...il.com, tonylu@...ux.alibaba.com, netdev@...r.kernel.org Subject: Re: [PATCH] net: sched: keep __gnet_stats_copy_xxx() same semantics for percpu stats On 12/1/19 4:22 AM, David Miller wrote: > From: Dust Li <dust.li@...ux.alibaba.com> > Date: Thu, 28 Nov 2019 14:30:48 +0800 > >> __gnet_stats_copy_basic/queue() support both percpu stat and >> non-percpu stat, but they are handle in a different manner: >> 1. For percpu stat, percpu stats are added to the return value; >> 2. For non-percpu stat, non-percpu stats will overwrite the >> return value; >> We should keep the same semantics for both type. >> >> This patch makes percpu stats follow non-percpu's manner by >> reset the return bstats before add the percpu bstats to it. >> Also changes the caller in sch_mq.c/sch_mqprio.c to make sure >> they dump the right statistics for percpu qdisc. >> >> One more thing, the sch->q.qlen is not set with nonlock child >> qdisc in mq_dump()/mqprio_dump(), add that. >> >> Fixes: 22e0f8b9322c ("net: sched: make bstats per cpu and estimator RCU safe") >> Signed-off-by: Dust Li <dust.li@...ux.alibaba.com> >> Signed-off-by: Tony Lu <tonylu@...ux.alibaba.com> > You are changing way too many things at one time here. > > Fix one bug in one patch, for example just fix the missed > initialization of the per-cpu stats. > > The qlen fix is another patch. > > And so on and so forth. > > Thank you. OK, I will separate them. Thanks for review ! Thanks. Dust Li
Powered by blists - more mailing lists