netdev - Re: [PATCH] net: sched: fix wrong class stats dumping in sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c971b372-97f3-3e53-3e33-403602b4e222@linux.alibaba.com>
Date:   Mon, 2 Dec 2019 19:18:20 +0800
From:   Dust Li <dust.li@...ux.alibaba.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        John Fastabend <john.fastabend@...il.com>,
        Tony Lu <tonylu@...ux.alibaba.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: sched: fix wrong class stats dumping in sch_mqprio


On 11/30/19 1:48 PM, Cong Wang wrote:
> On Wed, Nov 27, 2019 at 10:31 PM Dust Li <dust.li@...ux.alibaba.com> wrote:
>> Actually, the stack variables bstats and qstats in
>> mqprio_dump_class_stats() are not really used. As a result,
>> 'tc -s class show' for the mqprio class always return 0 for
>> both bstats and qstats. Use them to store the child qdisc's
>> stats and add them up as the stats for the mqprio class.
> This patch is on top of the previous one you sent, so please group
> and number them as "Patch X/N", otherwise it is confusing.
>
> Thanks.

OK, Thanks for your kind advice, I'll group them and re-send.


Thanks.

Dust Li