netdev - Re: [PATCH net] tcp: refactor tcp_retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+LK6wHWStHTn3swgx8KDGQ2VMULk59JaRWi599=yx2pw@mail.gmail.com>
Date:   Tue, 3 Dec 2019 11:15:31 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net] tcp: refactor tcp_retransmit_timer()

On Tue, Dec 3, 2019 at 11:13 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Tue, Dec 03, 2019 at 08:05:52AM -0800, Eric Dumazet wrote:
> > It appears linux-4.14 stable needs a backport of commit
> > 88f8598d0a30 ("tcp: exit if nothing to retransmit on RTO timeout")
> >
> > Since tcp_rtx_queue_empty() is not in pre 4.15 kernels,
> > let's refactor tcp_retransmit_timer() to only use tcp_rtx_queue_head()
>
> So does that mean that 4.19.y should get 88f8598d0a30 ("tcp: exit if
> nothing to retransmit on RTO timeout") as-is?
>

Yes indeed. All stable versions need it.

> > I will provide to stable teams the squashed patches.
>
> This is that squashed patch, right?

Yes, both patches squashed to avoid breaking future bisections.