netdev - Re: [PATCH v2] net: fix a leak in register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191203.111951.52254124666913970.davem@davemloft.net>
Date:   Tue, 03 Dec 2019 11:19:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     jiri@...lanox.com, wharms@....de, idosch@...lanox.com,
        petrm@...lanox.com, pabeni@...hat.com, edumazet@...gle.com,
        ap420073@...il.com, stephen@...workplumber.org, alobakin@...nk.ru,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] net: fix a leak in register_netdevice()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Tue, 3 Dec 2019 17:12:39 +0300

> We have to free "dev->name_node" on this error path.
> 
> Fixes: ff92741270bf ("net: introduce name_node struct to be used in hashlist")
> Reported-by: syzbot+6e13e65ffbaa33757bcb@...kaller.appspotmail.com
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> v2: dev->name_node can't be NULL so we can remove the check for that
>     in the cleanup code.

Applied, thanks Dan.