netdev - Re: [PATCH net] tcp: refactor tcp_retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20191203211559.GA3269042@kroah.com>
Date:   Tue, 3 Dec 2019 22:15:59 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net] tcp: refactor tcp_retransmit_timer()

On Tue, Dec 03, 2019 at 12:51:18PM -0800, Eric Dumazet wrote:
> On Tue, Dec 3, 2019, 12:24 PM Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> > On Tue, Dec 03, 2019 at 11:53:11AM -0800, David Miller wrote:
> > > From: Eric Dumazet <edumazet@...gle.com>
> > > Date: Tue,  3 Dec 2019 08:05:52 -0800
> > >
> > > > It appears linux-4.14 stable needs a backport of commit
> > > > 88f8598d0a30 ("tcp: exit if nothing to retransmit on RTO timeout")
> > > >
> > > > Since tcp_rtx_queue_empty() is not in pre 4.15 kernels,
> > > > let's refactor tcp_retransmit_timer() to only use tcp_rtx_queue_head()
> > > >
> > > > I will provide to stable teams the squashed patches.
> > > >
> > > > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > >
> > > Applied, thanks Eric.
> >
> > Applied where, do you have a 4.14-stable queue too?  :)
> >
> > I can just take this directly to my 4.14.y tree now if you don't object.
> >
> 
> Sure, please do, I will double-check it ;)

Ah, nevermind, I see now that your patch does apply to Dave's tree.  I
thought this was a 4.14-only thing here.

sorry for the confusion, I'll just ignore this for now then.

greg k-h