netdev - Re: [PATCH net] tcp: refactor tcp_retransmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191203.131844.1288568107728597971.davem@davemloft.net>
Date:   Tue, 03 Dec 2019 13:18:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     gregkh@...uxfoundation.org
Cc:     edumazet@...gle.com, netdev@...r.kernel.org,
        eric.dumazet@...il.com, soheil@...gle.com, ncardwell@...gle.com,
        ycheng@...gle.com, willemb@...gle.com
Subject: Re: [PATCH net] tcp: refactor tcp_retransmit_timer()

From: Greg KH <gregkh@...uxfoundation.org>
Date: Tue, 3 Dec 2019 21:23:58 +0100

> On Tue, Dec 03, 2019 at 11:53:11AM -0800, David Miller wrote:
>> From: Eric Dumazet <edumazet@...gle.com>
>> Date: Tue,  3 Dec 2019 08:05:52 -0800
>> 
>> > It appears linux-4.14 stable needs a backport of commit
>> > 88f8598d0a30 ("tcp: exit if nothing to retransmit on RTO timeout")
>> > 
>> > Since tcp_rtx_queue_empty() is not in pre 4.15 kernels,
>> > let's refactor tcp_retransmit_timer() to only use tcp_rtx_queue_head()
>> > 
>> > I will provide to stable teams the squashed patches.
>> > 
>> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> 
>> Applied, thanks Eric.
> 
> Applied where, do you have a 4.14-stable queue too?  :)

Applied to my net GIT tree, I do not have a 4.14 -stable queue :-)

> I can just take this directly to my 4.14.y tree now if you don't object.

Please integrate all of the -stable parts, yes.

Thanks.