netdev - Re: [PATCH] ARM: dts: BCM5301X: Fix MDIO node address/size cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Dec 2019 10:31:51 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-arm-kernel@...r.kernel.org, grygorii.strashko@...com,
        robh+dt@...nel.org, rafal@...ecki.pl, davem@...emloft.net,
        andrew@...n.ch, mark.rutland@....com, devicetree@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: BCM5301X: Fix MDIO node address/size cells

On Thu, Dec 05, 2019 at 04:04:21PM -0800, Florian Fainelli wrote:
> The MDIO node on BCM5301X had an reversed #address-cells and
>  #size-cells properties, correct those, silencing checker warnings:
> 
> .../linux/arch/arm/boot/dts/bcm4708-asus-rt-ac56u.dt.yaml: mdio@...03000: #address-cells:0:0: 1 was expected
> 
> Reported-by: Simon Horman <simon.horman@...ronome.com>
> Fixes: 23f1eca6d59b ("ARM: dts: BCM5301X: Specify MDIO bus in the DT")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Thanks, make dtbs_check seems a lot happier now.

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

FWIIW, I think a similar change might also be in order for bcm-cygnus.dtsi.

> ---
>  arch/arm/boot/dts/bcm5301x.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
> index 372dc1eb88a0..2d9b4dd05830 100644
> --- a/arch/arm/boot/dts/bcm5301x.dtsi
> +++ b/arch/arm/boot/dts/bcm5301x.dtsi
> @@ -353,8 +353,8 @@
>  	mdio: mdio@...03000 {
>  		compatible = "brcm,iproc-mdio";
>  		reg = <0x18003000 0x8>;
> -		#size-cells = <1>;
> -		#address-cells = <0>;
> +		#size-cells = <0>;
> +		#address-cells = <1>;
>  	};
>  
>  	mdio-bus-mux@...03000 {
> -- 
> 2.17.1
>