netdev - [PATCH][v2] page_pool: handle page recycle for NUMA_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1575624767-3343-1-git-send-email-lirongqing@baidu.com>
Date:   Fri,  6 Dec 2019 17:32:47 +0800
From:   Li RongQing <lirongqing@...du.com>
To:     netdev@...r.kernel.org, saeedm@...lanox.com, linyunsheng@...wei.com
Subject: [PATCH][v2] page_pool: handle page recycle for NUMA_NO_NODE condition

some drivers uses page pool, but not require to allocate
pages from bound node, or simply assign pool.p.nid to
NUMA_NO_NODE, and the commit d5394610b1ba ("page_pool:
Don't recycle non-reusable pages") will block this kind
of driver to recycle

so take page as reusable when page belongs to current
memory node if nid is NUMA_NO_NODE

v1-->v2: add check with numa_mem_id from Yunsheng

Fixes: d5394610b1ba ("page_pool: Don't recycle non-reusable pages")
Signed-off-by: Li RongQing <lirongqing@...du.com>
Suggested-by: Yunsheng Lin <linyunsheng@...wei.com>
Cc: Saeed Mahameed <saeedm@...lanox.com>
---
 net/core/page_pool.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index a6aefe989043..3c8b51ccd1c1 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -312,12 +312,17 @@ static bool __page_pool_recycle_direct(struct page *page,
 /* page is NOT reusable when:
  * 1) allocated when system is under some pressure. (page_is_pfmemalloc)
  * 2) belongs to a different NUMA node than pool->p.nid.
+ * 3) belongs to a different memory node than current context
+ * if pool->p.nid is NUMA_NO_NODE
  *
  * To update pool->p.nid users must call page_pool_update_nid.
  */
 static bool pool_page_reusable(struct page_pool *pool, struct page *page)
 {
-	return !page_is_pfmemalloc(page) && page_to_nid(page) == pool->p.nid;
+	return !page_is_pfmemalloc(page) &&
+		(page_to_nid(page) == pool->p.nid ||
+		(pool->p.nid == NUMA_NO_NODE &&
+		page_to_nid(page) == numa_mem_id()));
 }
 
 void __page_pool_put_page(struct page_pool *pool, struct page *page,
-- 
2.16.2