netdev - Re: [PATCH] dt-bindings: net: mdio: use non vendor specific compatible string in example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKZ5qexJMSm5MZYQp5LutyHHHObbfA3r2_XQa7E6kjqpg@mail.gmail.com>
Date:   Fri, 6 Dec 2019 09:09:12 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Grygorii Strashko <grygorii.strashko@...com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org,
        Simon Horman <simon.horman@...ronome.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: net: mdio: use non vendor specific
 compatible string in example

On Fri, Dec 6, 2019 at 5:14 AM Grygorii Strashko
<grygorii.strashko@...com> wrote:
>
>
>
> On 05/12/2019 19:59, Rob Herring wrote:
> > On Wed, Nov 27, 2019 at 9:39 AM Grygorii Strashko
> > <grygorii.strashko@...com> wrote:
> >>
> >> Use non vendor specific compatible string in example, otherwise DT YAML
> >> schemas validation may trigger warnings specific to TI ti,davinci_mdio
> >> and not to the generic MDIO example.
> >>
> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> >> ---
> >>   Documentation/devicetree/bindings/net/mdio.yaml | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/mdio.yaml b/Documentation/devicetree/bindings/net/mdio.yaml
> >> index 5d08d2ffd4eb..524f062c6973 100644
> >> --- a/Documentation/devicetree/bindings/net/mdio.yaml
> >> +++ b/Documentation/devicetree/bindings/net/mdio.yaml
> >> @@ -56,7 +56,7 @@ patternProperties:
> >>   examples:
> >>     - |
> >>       davinci_mdio: mdio@...30000 {
> >> -        compatible = "ti,davinci_mdio";
> >> +        compatible = "vendor,mdio";
> >
> > The problem with this is eventually 'vendor,mdio' will get flagged as
> > an undocumented compatible. We're a ways off from being able to enable
> > that until we have a majority of bindings converted. Though maybe
> > examples can be enabled sooner rather than later.
> >
>
> May be some generic compatible string be used for all examples,
> like: "vendor,example-ip". What do you think?

I'm still not clear what problem you are trying to solve. 'may trigger
warnings' doesn't sound like an actual problem.

Either make the example complete enough to pass validation or just
remove it because common bindings aren't a complete binding on their
own. I'm sure there will be plenty of other MDIO binding examples.

Rob