netdev - Re: [PATCH net-next v2 02/14] net: sfp: derive interface mode from ethtool link modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191210165345.GH27714@lunn.ch>
Date:   Tue, 10 Dec 2019 17:53:45 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 02/14] net: sfp: derive interface mode from
 ethtool link modes

On Mon, Dec 09, 2019 at 03:18:34PM +0000, Russell King wrote:
> We don't need the EEPROM ID to derive the phy interface mode as we can
> derive it merely from the ethtool link modes.  Remove the EEPROM ID
> argument to sfp_select_interface().
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew