netdev - Re: [PATCH net-next v2 04/14] net: sfp: add module start/stop upstream notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191210165919.GJ27714@lunn.ch>
Date:   Tue, 10 Dec 2019 17:59:19 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 04/14] net: sfp: add module start/stop
 upstream notifications

On Mon, Dec 09, 2019 at 03:18:44PM +0000, Russell King wrote:
> When dealing with some copper modules, we can't positively know the
> module capabilities are until we have probed the PHY. Without the full
> capabilities, we may end up failing a module that we could otherwise
> drive with a restricted set of capabilities.
> 
> An example of this would be a module with a NBASE-T PHY plugged into
> a host that supports phy interface modes 2500BASE-X and SGMII. The
> PHY supports 10GBASE-R, 5000BASE-X, 2500BASE-X, SGMII interface modes,
> which means a subset of the capabilities are compatible with the host.
> 
> However, reading the module EEPROM leads us to believe that the module
> only supports ethtool link mode 10GBASE-T, which is incompatible with
> the host - and thus results in the module being rejected.
> 
> This patch adds an extra notification which are triggered after the
> SFP module's PHY probe, and a corresponding notification just before
> the PHY is removed.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew