netdev - Re: [PATCH net-next v2 13/14] net: phy: add Broadcom BCM84881 PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <557220a9-bdf4-868a-d9cd-a382ae80d288@gmail.com>
Date:   Tue, 10 Dec 2019 09:34:16 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 13/14] net: phy: add Broadcom BCM84881 PHY
 driver

On 12/9/19 7:19 AM, Russell King wrote:
> Add a rudimentary Clause 45 driver for the BCM84881 PHY, found on
> Methode DM7052 SFPs.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

> ---
>  drivers/net/phy/Kconfig    |   6 +
>  drivers/net/phy/Makefile   |   1 +
>  drivers/net/phy/bcm84881.c | 269 +++++++++++++++++++++++++++++++++++++
>  3 files changed, 276 insertions(+)
>  create mode 100644 drivers/net/phy/bcm84881.c
> 
> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
> index fe602648b99f..41272106dea9 100644
> --- a/drivers/net/phy/Kconfig
> +++ b/drivers/net/phy/Kconfig
> @@ -329,6 +329,12 @@ config BROADCOM_PHY
>  	  Currently supports the BCM5411, BCM5421, BCM5461, BCM54616S, BCM5464,
>  	  BCM5481, BCM54810 and BCM5482 PHYs.
>  
> +config BCM84881_PHY
> +	bool "Broadcom BCM84881 PHY"
> +	depends on PHYLIB=y
> +	---help---
> +	  Support the Broadcom BCM84881 PHY.

Cannot we make this tristate, I believe we cannot until there are more
fundamental issues (that you just reported) to be fixed, correct?
-- 
Florian