lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e27cd48c-c5cc-bcf7-d80a-c234d207be32@gmail.com> Date: Wed, 11 Dec 2019 08:44:08 -0700 From: David Ahern <dsahern@...il.com> To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org Cc: Jakub Kicinski <jakub.kicinski@...ronome.com>, Jiri Benc <jbenc@...hat.com>, David Miller <davem@...emloft.net> Subject: Re: [PATCH net] ipv6/addrconf: only check invalid header values when NETLINK_F_STRICT_CHK is set On 12/11/19 7:20 AM, Hangbin Liu wrote: > In patch 4b1373de73a3 ("net: ipv6: addr: perform strict checks also for doit > handlers") we add strict check for inet6_rtm_getaddr(). But we did the > invalid header values check before checking if NETLINK_F_STRICT_CHK is > set. This may break backwards compatibility if user already set the > ifm->ifa_prefixlen, ifm->ifa_flags, ifm->ifa_scope in their netlink code. > > I didn't move the nlmsg_len check becuase I thought it's a valid check. > > Reported-by: Jianlin Shi <jishi@...hat.com> > Fixes: 4b1373de73a3 ("net: ipv6: addr: perform strict checks also for doit handlers") > Signed-off-by: Hangbin Liu <liuhangbin@...il.com> > --- > net/ipv6/addrconf.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Looks right to me. Reviewed-by: David Ahern <dsahern@...il.com>
Powered by blists - more mailing lists