lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87fthqu6y6.fsf@tarshish> Date: Wed, 11 Dec 2019 19:07:29 +0200 From: Baruch Siach <baruch@...s.co.il> To: Andrew Lunn <andrew@...n.ch> Cc: Vivien Didelot <vivien.didelot@...il.com>, netdev@...r.kernel.org, Denis Odintsov <d.odintsov@...viangames.com>, Hubert Feurstein <h.feurstein@...il.com> Subject: Re: [BUG] mv88e6xxx: tx regression in v5.3 Hi Andrew, On Wed, Dec 11 2019, Andrew Lunn wrote: > On Wed, Dec 11, 2019 at 11:48:57AM +0200, Baruch Siach wrote: >> Hi Andrew, Vivien, >> >> Since kernel v5.3 (tested v5.3.15), the 88E6141 switch on SolidRun >> Clearfog GT-8K stopped transmitting packets on switch connected >> ports. Kernel v5.2 works fine (tested v5.2.21). >> >> Here are the relevant kernel v5.3 log lines: >> >> [ 2.867424] mv88e6085 f412a200.mdio-mii:04: switch 0x3400 detected: Marvell 88E6141, revision 0 >> [ 2.927445] libphy: mdio: probed >> [ 3.578496] mv88e6085 f412a200.mdio-mii:04 lan2 (uninitialized): PHY [!cp1!config-space@...00000!mdio@...200!switch0@...dio:11] driver [Marvell 88E6390] >> [ 3.595674] mv88e6085 f412a200.mdio-mii:04 lan1 (uninitialized): PHY [!cp1!config-space@...00000!mdio@...200!switch0@...dio:12] driver [Marvell 88E6390] >> [ 3.612797] mv88e6085 f412a200.mdio-mii:04 lan4 (uninitialized): PHY [!cp1!config-space@...00000!mdio@...200!switch0@...dio:13] driver [Marvell 88E6390] >> [ 3.629910] mv88e6085 f412a200.mdio-mii:04 lan3 (uninitialized): PHY [!cp1!config-space@...00000!mdio@...200!switch0@...dio:14] driver [Marvell 88E6390] >> [ 3.646049] mv88e6085 f412a200.mdio-mii:04: configuring for phy/ link mode >> [ 3.654451] DSA: tree 0 setup >> ... >> [ 10.784521] mvpp2 f4000000.ethernet eth2: configuring for fixed/2500base-x link mode >> [ 10.792401] mvpp2 f4000000.ethernet eth2: Link is Up - 2.5Gbps/Full - flow control off >> [ 19.817981] mv88e6085 f412a200.mdio-mii:04 lan1: configuring for phy/ link mode >> [ 19.827083] 8021q: adding VLAN 0 to HW filter on device lan1 >> [ 21.577276] mv88e6085 f412a200.mdio-mii:04 lan1: Link is Up - 100Mbps/Full - flow control rx/tx >> [ 21.586030] IPv6: ADDRCONF(NETDEV_CHANGE): lan1: link becomes ready >> >> The Tx count on the lan1 interface increments, but the ARP packets don't >> show on the network. > > Hi Baruch > > I don't know of an issues. > > If the MAC TX counter increases, it sounds like it is a PHY issue? > Does 100Mbps/Full make sense for this link? 100Mbps switch is what I have at the other side of the link. Works perfectly with v5.2. > Probably your best bet is to do a git bisect to find which commit > broke it. Bisect points at 7fb5a711545d ("net: dsa: mv88e6xxx: drop adjust_link to enabled phylink"). Reverting this commit on top of v5.3.15 fixes the issue (and brings the warning back). As I understand, this basically reverts the driver migration to phylink. What might be the issue with phylink? Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
Powered by blists - more mailing lists