netdev - Re: [BUG] mv88e6xxx: tx regression in v5.3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191211174938.GB30053@lunn.ch>
Date:   Wed, 11 Dec 2019 18:49:38 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     Vivien Didelot <vivien.didelot@...il.com>, netdev@...r.kernel.org,
        Denis Odintsov <d.odintsov@...viangames.com>,
        Hubert Feurstein <h.feurstein@...il.com>
Subject: Re: [BUG] mv88e6xxx: tx regression in v5.3

> Bisect points at 7fb5a711545d ("net: dsa: mv88e6xxx: drop adjust_link to
> enabled phylink"). Reverting this commit on top of v5.3.15 fixes the
> issue (and brings the warning back). As I understand, this basically
> reverts the driver migration to phylink. What might be the issue with
> phylink?

That suggests the MAC is wrongly running at 1G, and the PHY at 100M,
which is why it does not work.

You probably want to add #define DEBUG to the top of phylink.c, and
scatter some debug prints in mv88e6xxx_mac_config(). My guess would
be, either mv88e6xxx_mac_config() is existing before configuring the
MAC, or mv88e6xxx_port_setup_mac() has wrongly decided nothing has
changed and so has not configured the MAC.

	Andrew