lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20191211.120120.991784482938734303.davem@davemloft.net> Date: Wed, 11 Dec 2019 12:01:20 -0800 (PST) From: David Miller <davem@...emloft.net> To: vivien.didelot@...il.com Cc: nikolay@...ulusnetworks.com, dsahern@...il.com, roopa@...ulusnetworks.com, netdev@...r.kernel.org, bridge@...ts.linux-foundation.org, stephen@...workplumber.org Subject: Re: [PATCH net-next v2] net: bridge: add STP xstats From: Vivien Didelot <vivien.didelot@...il.com> Date: Wed, 11 Dec 2019 13:41:33 -0500 > Hi David, Nikolay, > > On Wed, 11 Dec 2019 17:42:33 +0200, Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote: >> >> /* Bridge multicast database attributes >> >> * [MDBA_MDB] = { >> >> * [MDBA_MDB_ENTRY] = { >> >> @@ -261,6 +270,7 @@ enum { >> >> BRIDGE_XSTATS_UNSPEC, >> >> BRIDGE_XSTATS_VLAN, >> >> BRIDGE_XSTATS_MCAST, >> >> + BRIDGE_XSTATS_STP, >> >> BRIDGE_XSTATS_PAD, >> >> __BRIDGE_XSTATS_MAX >> >> }; >> > >> > Shouldn't the new entry be appended to the end - after BRIDGE_XSTATS_PAD >> > >> >> Oh yes, good catch. That has to be fixed, too. >> > > This I don't get. Why new attributes must come between BRIDGE_XSTATS_PAD > and __BRIDGE_XSTATS_MAX? Because, just like any other attribute value, BRIDGE_XSTATS_PAD is an API and fixed in stone. You can't add things before it which change it's value.
Powered by blists - more mailing lists