lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20191211215104.qnvifdmlg55ox45b@salvia> Date: Wed, 11 Dec 2019 22:51:04 +0100 From: Pablo Neira Ayuso <pablo@...filter.org> To: Xin Long <lucien.xin@...il.com> Cc: network dev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org, davem@...emloft.net Subject: Re: [PATCH nf-next 1/7] netfilter: nft_tunnel: parse ERSPAN_VERSION attr as u8 Hi, On Sun, Dec 08, 2019 at 12:41:31PM +0800, Xin Long wrote: > To keep consistent with ipgre_policy, it's better to parse > ERSPAN_VERSION attr as u8, as it does in act_tunnel_key, > cls_flower and ip_tunnel_core. > > Signed-off-by: Xin Long <lucien.xin@...il.com> > --- > net/netfilter/nft_tunnel.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/net/netfilter/nft_tunnel.c b/net/netfilter/nft_tunnel.c > index 3d4c2ae..f76cd7d 100644 > --- a/net/netfilter/nft_tunnel.c > +++ b/net/netfilter/nft_tunnel.c > @@ -248,8 +248,9 @@ static int nft_tunnel_obj_vxlan_init(const struct nlattr *attr, > } > > static const struct nla_policy nft_tunnel_opts_erspan_policy[NFTA_TUNNEL_KEY_ERSPAN_MAX + 1] = { > + [NFTA_TUNNEL_KEY_ERSPAN_VERSION] = { .type = NLA_U8 }, > [NFTA_TUNNEL_KEY_ERSPAN_V1_INDEX] = { .type = NLA_U32 }, > - [NFTA_TUNNEL_KEY_ERSPAN_V2_DIR] = { .type = NLA_U8 }, > + [NFTA_TUNNEL_KEY_ERSPAN_V2_DIR] = { .type = NLA_U8 }, > [NFTA_TUNNEL_KEY_ERSPAN_V2_HWID] = { .type = NLA_U8 }, > }; > > @@ -266,7 +267,7 @@ static int nft_tunnel_obj_erspan_init(const struct nlattr *attr, > if (err < 0) > return err; > > - version = ntohl(nla_get_be32(tb[NFTA_TUNNEL_KEY_ERSPAN_VERSION])); > + version = nla_get_u8(tb[NFTA_TUNNEL_KEY_ERSPAN_VERSION]); I think NFTA_TUNNEL_KEY_ERSPAN_VERSION as 32-bit is just fine. Netlink will be adding the padding anyway for u8. I would suggest you leave this as is. Thanks.
Powered by blists - more mailing lists