netdev - Re: [PATCH 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191210.170641.436017083129647530.davem@davemloft.net>
Date:   Tue, 10 Dec 2019 17:06:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     danielwa@...co.com
Cc:     gregkh@...uxfoundation.org, acj@...co.com, peppe.cavallaro@...com,
        netdev@...r.kernel.org, xe-linux-external@...co.com
Subject: Re: [PATCH 1/2] net: stmmac: use correct DMA buffer size in the RX
 descriptor

From: "Daniel Walker (danielwa)" <danielwa@...co.com>
Date: Tue, 10 Dec 2019 21:40:17 +0000

> On Tue, Dec 10, 2019 at 09:55:42PM +0100, Greg KH wrote:
>> On Tue, Dec 10, 2019 at 09:06:58AM -0800, Aviraj CJ wrote:
>> > We always program the maximum DMA buffer size into the receive descriptor,
>> > although the allocated size may be less. E.g. with the default MTU size
>> > we allocate only 1536 bytes. If somebody sends us a bigger frame, then
>> > memory may get corrupted.
>> > 
>> > Program DMA using exact buffer sizes.
>> > 
>> > [Adopted based on upstream commit c13a936f46e3321ad2426443296571fab2feda44
>> > ("net: stmmac: use correct DMA buffer size in the RX descriptor")
>> > by Aaro Koskinen <aaro.koskinen@...ia.com> ]
>> 
>> Adopted to what?
>> 
>> What is this patch for, it looks just like the commit you reference
>> here.
>> 
>> totally confused,
> 
> 
> We're using the patches on the v4.4 -stable branch. It doesn't have these patches and
> the backport had rejects.

As submitted the patch looks like something destined for mainline.

Not specifying the context into which the change is meant to be placed
wastes a lot of precious developer time.