netdev - Re: [PATCH net-next v2 00/14] Add support for SFP+ copper modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191210.172345.1443717103734845249.davem@davemloft.net>
Date:   Tue, 10 Dec 2019 17:23:45 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     linux@...linux.org.uk
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 00/14] Add support for SFP+ copper modules

From: Russell King - ARM Linux admin <linux@...linux.org.uk>
Date: Mon, 9 Dec 2019 15:15:53 +0000

> This series adds support for Copper SFP+ modules with Clause 45 PHYs.
> Specifically the patches:

This series needs some work actually:

1) Patch #6 adds the following warning:

drivers/net/phy/phylink.c: In function ‘phylink_attach_phy’:
drivers/net/phy/phylink.c:770:6: warning: unused variable ‘ret’ [-Wunused-variable]

2) Patch #11 adds a reference to ML_AN_INBAND which breaks the build:

drivers/net/phy/phylink.c: In function ‘phylink_sfp_connect_phy’:
drivers/net/phy/phylink.c:1856:31: error: ‘ML_AN_INBAND’ undeclared (first use in this function); did you mean ‘MLO_AN_INBAND’?
  ret = phylink_sfp_config(pl, ML_AN_INBAND, phy->supported,
                               ^~~~~~~~~~~~
                               MLO_AN_INBAND

3) Patch #12 removes this line.

Please fix the warning and make this patch series properly bisectable.

You have all the ACKs, so once this is fixed up I'll apply it.

Thanks.