netdev - Re: [PATCH net-next] Revert "nfp: abm: fix memory leak in nfp_abm_u32_knode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191213181549.0357de09@cakuba.netronome.com>
Date:   Fri, 13 Dec 2019 18:15:49 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        John Hurley <john.hurley@...ronome.com>
Subject: Re: [PATCH net-next] Revert "nfp: abm: fix memory leak in
 nfp_abm_u32_knode_replace"

On Tue, 10 Dec 2019 10:20:32 -0800, Jakub Kicinski wrote:
> This reverts commit 78beef629fd9 ("nfp: abm: fix memory leak in
> nfp_abm_u32_knode_replace").
> 
> The quoted commit does not fix anything and resulted in a bogus
> CVE-2019-19076.
> 
> If match is NULL then it is known there is no matching entry in
> list, hence, calling nfp_abm_u32_knode_delete() is pointless.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: John Hurley <john.hurley@...ronome.com>

Applied.