netdev - Re: [PATCH net] tcp/dccp: fix possible race __inet_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191213181654.33e5999e@cakuba.netronome.com>
Date:   Fri, 13 Dec 2019 18:16:54 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Michal Kubecek <mkubecek@...e.cz>, netdev@...r.kernel.org,
        Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Firo Yang <firo.yang@...e.com>
Subject: Re: [PATCH net] tcp/dccp: fix possible race
 __inet_lookup_established()

On Fri, 13 Dec 2019 17:57:23 -0800, Eric Dumazet wrote:
> On 12/13/19 5:52 PM, Jakub Kicinski wrote:
> > I need to remove a whitespace here:
> > 
> > WARNING: Block comments should align the * on each line
> > #98: FILE: include/net/inet_hashtables.h:111:
> > + * reallocated/inserted into established hash table
> > +  */
> > 
> > So last chance to adjust the comment as well - perhaps we can
> > s/into/from/ on the last line? 
> > 
> > Or say "or we might find an established socket that was closed and
> > reallocated/inserted into different hash table" ?
> > 
> > IMHO confusing comment is worse than no comment at all :S
> >   
> 
> Sure, I will send a V2.

Oh even better, thank you!