netdev - RE: [PATCH net 0/8] net: stmmac: Fixes for -net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Dec 2019 09:26:22 +0000
From:   Jose Abreu <Jose.Abreu@...opsys.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        "David S. Miller" <davem@...emloft.net>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net 0/8] net: stmmac: Fixes for -net

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Dec/14/2019, 00:22:16 (UTC+00:00)

> On Tue, 10 Dec 2019 20:33:52 +0100, Jose Abreu wrote:
> > Fixes for stmmac.
> > 
> > 1) Fixes the filtering selftests (again) for cases when the number of multicast
> > filters are not enough.
> > 
> > 2) Fixes SPH feature for MTU > default.
> > 
> > 3) Fixes the behavior of accepting invalid MTU values.
> > 
> > 4) Fixes FCS stripping for multi-descriptor packets.
> > 
> > 5) Fixes the change of RX buffer size in XGMAC.
> > 
> > 6) Fixes RX buffer size alignment.
> > 
> > 7) Fixes the 16KB buffer alignment.
> > 
> > 8) Fixes the enabling of 16KB buffer size feature.
> 
> Hi Jose!
> 
> Patches directed at net should have a Fixes tag identifying the commit
> which introduced the problem. The commit messages should also describe
> user-visible outcomes of the bugs. Without those two its hard to judge
> which patches are important for stable backports.
> 
> Could you please repost with appropriate Fixes tags?

I agree with you Jakub but although these are bugs they are either for 
recently introduced features (such as SPH and selftests), or for 
features that are not commonly used. I can dig into the GIT history and 
provide fixes tag for them all or I can always provide a backport fix if 
any user requires so. Can you please comment on which one you prefer ?

---
Thanks,
Jose Miguel Abreu