netdev - Re: [PATCH net-next 06/11] net: phy: marvell: initialise link partner state earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bf81637-2b80-6614-db83-2a65787c0a4b@gmail.com>
Date:   Tue, 17 Dec 2019 09:30:41 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 06/11] net: phy: marvell: initialise link partner
 state earlier

On 12/17/19 5:39 AM, Russell King wrote:
> Move the initialisation of the link partner state earlier, inside
> marvell_read_status_page(), so we don't have the same initialisation
> scattered amongst the other files.  This is in a similar place to
> the genphy implementation, so would result in the same behaviour if
> a PHY read error occurs.
> 
> This allows us to get rid of marvell_read_status_page_fixed(), which
> became a pointless wrapper around genphy_read_status_fixed().
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian