netdev - Re: [PATCH net-next v3 3/3] openvswitch: New MPLS actions for layer 2 tunnelling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191217093025.71f33a09@cakuba.netronome.com>
Date:   Tue, 17 Dec 2019 09:30:25 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Martin Varghese <martinvarghesenokia@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, pshelar@....org,
        scott.drennan@...ia.com, jbenc@...hat.com,
        martin.varghese@...ia.com
Subject: Re: [PATCH net-next v3 3/3] openvswitch: New MPLS actions for layer
 2 tunnelling

On Tue, 17 Dec 2019 22:45:39 +0530, Martin Varghese wrote:
> On Mon, Dec 16, 2019 at 04:13:55PM -0800, Jakub Kicinski wrote:
> > On Mon, 16 Dec 2019 19:33:43 +0530, Martin Varghese wrote:  
> > > diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h
> > > index a87b44c..b7221ad 100644
> > > --- a/include/uapi/linux/openvswitch.h
> > > +++ b/include/uapi/linux/openvswitch.h
> > > @@ -673,6 +673,25 @@ struct ovs_action_push_mpls {
> > >  };
> > >  
> > >  /**
> > > + * struct ovs_action_ptap_push_mpls - %OVS_ACTION_ATTR_PTAP_PUSH_MPLS action
> > > + * argument.
> > > + * @mpls_lse: MPLS label stack entry to push.
> > > + * @mpls_ethertype: Ethertype to set in the encapsulating ethernet frame.
> > > + * @l2_tun: Flag to specify the place of insertion of MPLS header.
> > > + * When true, the MPLS header will be inserted at the start of the packet.
> > > + * When false, the MPLS header will be inserted at the start of the l3 header.
> > > + *
> > > + * The only values @mpls_ethertype should ever be given are %ETH_P_MPLS_UC and
> > > + * %ETH_P_MPLS_MC, indicating MPLS unicast or multicast. Other are rejected.
> > > + */
> > > +struct ovs_action_ptap_push_mpls {
> > > +	__be32 mpls_lse;
> > > +	__be16 mpls_ethertype; /* Either %ETH_P_MPLS_UC or %ETH_P_MPLS_MC */
> > > +	bool l2_tun;  
> > 
> > In file included from <command-line>:32:                                        
> > ./usr/include/linux/openvswitch.h:674:2: error: unknown type name ‘bool’        
> >   674 |  bool l2_tun;                                                           
> >       |  ^~~~                                                                   
> > make[3]: *** [usr/include/linux/openvswitch.hdrtest] Error 1  
> >   
> 
> Does that mean bool cannot be used in interface header files ? but what is
> the alternative u8?

I think you have a 16 bit hole there anyway due to the alignment, so
I'd declare the space as __u16 (underscores needed since this is the
user space type), and then validate in the kernel that the higher bits
are unused i.e. return -EINVAL if the field is not 0 or 1, to allow for
a future use of those bits.