netdev - Re: [PATCH net-next 2/2] net/mlx5e: add mlx5e_rep_indr_setup_ft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62c3d7ec655b0209d2f5d573070e484ac561033c.camel@mellanox.com>
Date:   Tue, 17 Dec 2019 19:54:34 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "wenxu@...oud.cn" <wenxu@...oud.cn>,
        Paul Blakey <paulb@...lanox.com>,
        "pablo@...filter.org" <pablo@...filter.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/2] net/mlx5e: add mlx5e_rep_indr_setup_ft_cb
 support

On Wed, 2019-12-11 at 10:41 +0800, wenxu wrote:
> On 12/10/2019 7:44 PM, Paul Blakey wrote:
> > On 12/10/2019 12:08 PM, wenxu@...oud.cn wrote:
> > > From: wenxu <wenxu@...oud.cn>
> > > 
> > > Add mlx5e_rep_indr_setup_ft_cb to support indr block setup
> > > in FT mode.
> > > 
> > > Signed-off-by: wenxu <wenxu@...oud.cn>
> > > ---

[...]

> > +cc Saeed
> > 
> > 
> > This looks good to me, but it should be on top of a patch that
> > will 
> > actual allows the indirect BIND if the nft
> > 
> > table device is a tunnel device. Is that upstream? If so which
> > patch?
> > 
> > 
> > Currently (5.5.0-rc1+), nft_register_flowtable_net_hooks calls 
> > nf_flow_table_offload_setup which will see
> > 
> > that the tunnel device doesn't have ndo_setup_tc and return 
> > -EOPNOTSUPPORTED.
> 
> The related patch  http://patchwork.ozlabs.org/patch/1206935/
> 
> is waiting for upstream
> 

The netfilter patch is still under-review, once accepted i will apply
this series.

Thanks,
Saeed.